Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"How to Issue JSON-LD Credentials using Aca-py" has invalid Admin API endpoint documentation #2041

Closed
jfblier-amplitude opened this issue Dec 7, 2022 · 3 comments
Closed

"How to Issue JSON-LD Credentials using Aca-py" has invalid Admin API endpoint documentation #2041

jfblier-amplitude opened this issue Dec 7, 2022 · 3 comments

Comments

@jfblier-amplitude
Copy link
Contributor

The documented endpoint /request-presentation-2.0/request-proof from https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/AliceWantsAJsonCredential.md#request-presentation-example doesn't exists.

/present-proof-2.0/send-request should be used with the automated flow.

Also there's an other mention to /request-presentation-2.0/{pres_ex_id}/send-presentation that should be updated.
@swcurran
Copy link
Contributor

swcurran commented Dec 7, 2022

Happy to get a PR :-).

@ianco -- FYI.

@jfblier-amplitude
Copy link
Contributor Author

Sure. Will work on it this weekend :-)

@swcurran , @ianco

@jfblier-amplitude
Copy link
Contributor Author

@swcurran @ianco
I submitted a PR https://github.com/hyperledger/aries-cloudagent-python/pull/2045
Thanks.

jfblier-amplitude added a commit to jfblier-amplitude/aries-cloudagent-python that referenced this issue Dec 13, 2022
@jfblier-amplitude
openwallet-foundation#2041 - Issue JSON-LD has invalid Admin API docu…
e976f08 
…mentation

Signed-off-by: Jean-Francois Blier <[email protected]>
ianco added a commit that referenced this issue Dec 24, 2022
@ianco
Merge pull request #2046 from jfblier-amplitude/main
929a09a 
#2041 - Issue JSON-LD has invalid Admin API documentation
@ianco ianco closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swcurran @ianco @jfblier-amplitude