feat: implement new wallet trait for askar #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2023
xprazak2
force-pushed
the
indy-record-wallet
branch
7 times, most recently
from
c572e24 to
550ae5d
Compare
xprazak2
force-pushed
the
indy-record-wallet
branch
10 times, most recently
from
d7199da to
748ab8a
Compare
xprazak2
force-pushed
the
indy-record-wallet
branch
5 times, most recently
from
bc3a5c6 to
91c0004
Compare
xprazak2
force-pushed
the
indy-record-wallet
branch
3 times, most recently
from
f85aedc to
55cbf0a
Compare
xprazak2
force-pushed
the
ai
branch
2 times, most recently
from
3fc31ec to
255acfc
Compare
Patrik-Stas
previously approved these changes
Feb 21, 2024
mirgee
previously approved these changes
Feb 22, 2024
added 3 commits
February 23, 2024 11:20
Signed-off-by: Ondrej Prazak <[email protected]>
Signed-off-by: Ondrej Prazak <[email protected]>
Signed-off-by: Ondrej Prazak <[email protected]>
xprazak2
force-pushed
the
ai
branch
9 times, most recently
from
d8d5345 to
76876a7
Compare
Signed-off-by: Ondrej Prazak <[email protected]>
xprazak2
force-pushed
the
ai
branch
6 times, most recently
from
a63dca0 to
a7db7f5
Compare
Signed-off-by: Ondrej Prazak <[email protected]>
Patrik-Stas
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include implementation of
BaseWalletfor askar.These changes intentionally do not include any data migrations between wallets using
BaseWalletor compatibility tests between different wallet implementations. Even though both of them are important, they are not needed for a new wallet implementation to work on its own, therefore they can (and will) be added separately as this is already large enough.