Uniffi simple message relay #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
2 times, most recently
from
33d6ab7 to
614f84b
Compare
Codecov Report
@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 30.02% 30.02%
=======================================
Files 415 415
Lines 26916 26916
Branches 5231 5243 +12
=======================================
Hits 8081 8081
Misses 16639 16639
Partials 2196 2196
Flags with carried forward coverage won't be shown. Click here to find out more. |
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
2 times, most recently
from
a0e3203 to
17e70ad
Compare
gmulhearn
reviewed
Sep 11, 2023
gmulhearn
reviewed
Sep 11, 2023
gmulhearn
reviewed
Sep 11, 2023
gmulhearn
reviewed
Sep 11, 2023
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
from
e602442 to
1f1fcda
Compare
swaptr
commented
Sep 11, 2023
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
4 times, most recently
from
329c75d to
d7aabec
Compare
gmulhearn
reviewed
Sep 18, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/ScanScreen.kt
Outdated
Show resolved
Hide resolved
gmulhearn
previously approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Nice work. This will be good to merge after we stop using walletKey as the user id; for now we can just use a hardcoded string: demo-user-1 for example.
And also as discussed, in a later PR we will look into cleaning up the app logic by putting a lot of the logic into a global "controller" class. this will let us clean up some of the HTTP polling logic currently within the HomeScreen
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
from
d7aabec to
6df61d6
Compare
gmulhearn
reviewed
Sep 24, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/HomeScreen.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
3 times, most recently
from
202f49d to
e142edb
Compare
Signed-off-by: Swapnil Tripathi <[email protected]>
swaptr
force-pushed
the
uniffi-simple-message-relay
branch
from
e142edb to
a81eb8c
Compare
gmulhearn
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.