-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection protocol: add encrypt_message, remove auto-problem-report sending #982
Conversation
Codecov Report
@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 30.02% 30.08% +0.05%
==========================================
Files 415 415
Lines 26916 26846 -70
Branches 5243 5233 -10
==========================================
- Hits 8081 8076 -5
+ Misses 16639 16574 -65
Partials 2196 2196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bb1adb1
to
97a5b15
Compare
692123c
to
b1db2cc
Compare
…arty DidDoc Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
a947dd8
to
28eb7b4
Compare
Signed-off-by: Patrik Stas <[email protected]>
28eb7b4
to
df76001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Addition:
encrypt_message
onimpl<I, S> Connection<I, S> where S: TheirDidDoc
Breaking change:
InviteeConnection<Requested>
methodhandle_response
, remove automatic problem-report sending in case of error processingconnection-response
message. The caller should, like in other protocols, inspect Error result returned and decide to send (or not) problem reportInviterConnection<Invited>
methodhandle_request
processing ofconnection-request
.Connection
for to dispatch problem report messages