Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection protocol: add encrypt_message, remove auto-problem-report sending #982

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Sep 15, 2023

Addition:

  • Add encrypt_message on impl<I, S> Connection<I, S> where S: TheirDidDoc

Breaking change:

  • For InviteeConnection<Requested> method handle_response, remove automatic problem-report sending in case of error processing connection-response message. The caller should, like in other protocols, inspect Error result returned and decide to send (or not) problem report
  • Same applies for InviterConnection<Invited> method handle_request processing of connection-request.
  • Remove methods defined on Connection for to dispatch problem report messages

@Patrik-Stas Patrik-Stas changed the title Implement encrypt_message for typestate Connection which has counterp… Implement encrypt_message for Connections with counterparty DidDoc Sep 15, 2023
@Patrik-Stas Patrik-Stas marked this pull request as draft September 15, 2023 23:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #982 (28eb7b4) into main (ecc2047) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 22.58%.

❗ Current head 28eb7b4 differs from pull request most recent head df76001. Consider uploading reports for the commit df76001 to get more accurate results

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   30.02%   30.08%   +0.05%     
==========================================
  Files         415      415              
  Lines       26916    26846      -70     
  Branches     5243     5233      -10     
==========================================
- Hits         8081     8076       -5     
+ Misses      16639    16574      -65     
  Partials     2196     2196              
Flag Coverage Δ
unittests-aries-vcx 30.08% <22.58%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aries_vcx/src/core/profile/ledger.rs 70.58% <ø> (-0.85%) ⬇️
aries_vcx/src/handlers/proof_presentation/types.rs 43.75% <ø> (-1.15%) ⬇️
aries_vcx/tests/utils/scenarios/connection.rs 89.24% <100.00%> (ø)
aries_vcx/src/common/credentials/mod.rs 82.81% <0.00%> (ø)
...ocols/proof_presentation/verifier/state_machine.rs 49.11% <0.00%> (-0.36%) ⬇️
aries_vcx/src/protocols/connection/invitee/mod.rs 78.94% <60.00%> (+8.85%) ⬆️
aries_vcx/src/protocols/connection/inviter/mod.rs 75.00% <33.33%> (+7.74%) ⬆️
aries_vcx/src/utils/devsetup.rs 42.20% <0.00%> (+0.16%) ⬆️
aries_vcx/src/protocols/connection/generic/mod.rs 9.16% <0.00%> (+0.20%) ⬆️
aries_vcx/src/protocols/connection/mod.rs 7.89% <0.00%> (+3.72%) ⬆️

... and 2 files with indirect coverage changes

@Patrik-Stas Patrik-Stas force-pushed the connection/encrypt-message branch 2 times, most recently from bb1adb1 to 97a5b15 Compare September 25, 2023 09:14
@Patrik-Stas Patrik-Stas changed the title Implement encrypt_message for Connections with counterparty DidDoc Connection protocol: add encrypt_message, remove auto-problem-report sending Sep 25, 2023
@Patrik-Stas Patrik-Stas force-pushed the connection/encrypt-message branch 2 times, most recently from 692123c to b1db2cc Compare September 25, 2023 12:02
@Patrik-Stas Patrik-Stas marked this pull request as ready for review September 25, 2023 15:07
@Patrik-Stas Patrik-Stas force-pushed the connection/encrypt-message branch from a947dd8 to 28eb7b4 Compare September 25, 2023 17:40
Signed-off-by: Patrik Stas <[email protected]>
@Patrik-Stas Patrik-Stas force-pushed the connection/encrypt-message branch from 28eb7b4 to df76001 Compare September 26, 2023 13:57
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Patrik-Stas Patrik-Stas merged commit 636c295 into main Sep 28, 2023
@Patrik-Stas Patrik-Stas deleted the connection/encrypt-message branch September 28, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants