Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vdrproxy CI job intermittent failures #994

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Conversation

bobozaur
Copy link
Contributor

@bobozaur bobozaur commented Sep 25, 2023

Attempts to fix the vdrproxy CI job by adding a health check action for the services ports.
Additionally, within the same action and some other, the Rust toolchain version was hardcoded, therefore tweaked the inputs to accept the version for consistency reasons.

Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the logs from the failed container

Listening on http://0.0.0.0:3030 ...
Error initializing pool: Pool timeout: Request was interrupted

it seems that the issue is that there's needs to be bit of timeout between the steps of starting indy pool and starting vdrproxy.

@bobozaur
Copy link
Contributor Author

bobozaur commented Sep 25, 2023

looking at the logs from the failed container

Listening on http://0.0.0.0:3030 ...
Error initializing pool: Pool timeout: Request was interrupted

it seems that the issue is that there's needs to be bit of timeout between the steps of starting indy pool and starting vdrproxy.

Hmmm... Okay, so it's not the proxy itself. Where did you get the container logs, though? As in, were they already present somewhere or did you do a custom run with something like docker logs?

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Sep 25, 2023

It's at the end of CI summary page, after scrolling through some CI warnings all the way down

image

Most of the jobs (or all) which run docker in CI, have this step on them:

      - name: "Collect docker logs on failure"
        if: failure()
        uses: ./.github/actions/upload-docker-logs
        with:
          name: "docker-services-${{ github.job }}"
          

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #994 (e617b20) into main (b71327e) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head e617b20 differs from pull request most recent head ad3c765. Consider uploading reports for the commit ad3c765 to get more accurate results

@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files         415      415           
  Lines       26916    26916           
  Branches     5243     5243           
=======================================
+ Hits         8081     8082    +1     
  Misses      16639    16639           
+ Partials     2196     2195    -1     
Flag Coverage Δ
unittests-aries-vcx 30.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Patrik-Stas Patrik-Stas merged commit ecc2047 into main Sep 25, 2023
@Patrik-Stas Patrik-Stas deleted the fix/vdrproxy_ci branch September 25, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants