Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to parameter as optional for eth_call #937

Merged

Conversation

rolandtyler
Copy link
Contributor

@rolandtyler rolandtyler commented Feb 1, 2022

Signed-off-by: Roland Tyler [email protected]

Describe the change

Remove the note stating the to parameter is required for transaction call object for eth_call

Issue fixed

Fixes #933

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

https://hyperledger-besu--937.org.readthedocs.build/en/937/Reference/API-Objects/#transaction-call-object

@rolandtyler rolandtyler requested a review from a team as a code owner February 1, 2022 18:44
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one I think it would also be good to add an example on the eth_call page with the "simulate a contract creation" scenario (ie include the request/response json)

@rolandtyler rolandtyler requested a review from macfarla February 2, 2022 19:29
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion.

docs/Reference/API-Objects.md Outdated Show resolved Hide resolved
@rolandtyler rolandtyler merged commit 2a183ab into hyperledger:main Feb 10, 2022
@rolandtyler rolandtyler deleted the Update-transaction-call-object branch February 10, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_call - to field now optional
3 participants