Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer list is not consistent tested with small network #3673

Closed
helderjnpinto opened this issue Apr 1, 2022 · 2 comments
Closed

Peer list is not consistent tested with small network #3673

helderjnpinto opened this issue Apr 1, 2022 · 2 comments
Labels
peering TeamRevenant GH issues worked on by Revenant Team

Comments

@helderjnpinto
Copy link
Contributor

helderjnpinto commented Apr 1, 2022

Description

As a blockchain client validador or not i want a list of a peers of my network not in duplicated and more consistent.

Acceptance Criteria

  • In small network (we talk about 4 validators) only of validators should by a consistent count between all peers
  • Not have duplicated nodes (like filter by enode public key and ip)

Steps to Reproduce (Bug)

  • I made a setup local with multiple clients using docker-compose below i will put my findings.

In the following tests i made with same group of validators that is composed by:
1 bootnode + validator IBFT 2.0
3 validators IBFT 2.0

Test 1 - Testing only a small group of validators

Peers-testing-besu drawio (4 valid)

e5a63673898f226ce8f5a56de2fc2293

This result some times give the same amount of peers should be 4 on each of them that i think it is correct i suppose.
working dockers more than 30 min.

Test 2 - Testing only a small group of validators + clients

f4c4304b0b834365b0a84c12a1833771

6fc776bcc1fa4c27baafb65e333cc532

Some result as test 1 the peers count never is equal working time > 1h.

Test 3 - Testing validators + clients with other parameters

5832ed7b68d74e8eadc89c3e0dc0cd77

195f4023bda3419893c3a5de7ffb4ea7

some of the peers have duplicated peer enode but network property have different ports (at first time i thought maybe is a docker-compose thing) but when i checked my aws network i also have duplicate enodes and this exists in different pods.

c8b3e24761a94493a29dedb21f0d66cd

Additional Information (Add any of the following or anything else that may be relevant)

  • i5, 16 GB RAM.
@frankisawesome
Copy link
Contributor

Thanks for the detailed report - this is a known issue that's currently in our backlog, we had a draft PR up but other priorities came up so it's pending further work, we'll use this issue and report back once progress is made.

Feel free to look at the draft pr in the meantime #3383

@frankisawesome frankisawesome added the TeamRevenant GH issues worked on by Revenant Team label Apr 4, 2022
@macfarla
Copy link
Contributor

For clarity @helderjnpinto we are closing this issue as a duplicate - this will be addressed as part of the work for #2689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peering TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

No branches or pull requests

4 participants