Change map key in eth peers #3383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Pingel <[email protected]>
Signed-off-by: Stefan Pingel <[email protected]>
|
@pinges hey all good ? when this PR will be fixed and merged, any time estimation? I have in my network one peer duplicated 1088 times :). |
jflo
approved these changes
Apr 11, 2022
| @@ -118,8 +120,8 @@ private void abortPendingRequestsAssignedToDisconnectedPeers() { | |||
| } | |||
| } | |||
|
|
|||
| public EthPeer peer(final PeerConnection peerConnection) { | |||
There was a problem hiding this comment.
I don't think the public interface method to this class needs a type change. It's fine to make the internal map keyed by Bytes, but I think the public interface method into EthPeers gets less readable when we make the parameter more primitive. Can we keep the
parameter as a PeerConnection, and just interact with the Map using its getPeer().getId()?
|
@pinges are you closing this PR in favour of your new approach? |
|
Closing this in favour of a new approach cc @pinges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix multiple connections to the same peer by using the peer id as the key to the map