Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename genesis config option Ecip1099Block to ThanosBlock #1462

Merged
merged 2 commits into from
Oct 15, 2020
Merged

rename genesis config option Ecip1099Block to ThanosBlock #1462

merged 2 commits into from
Oct 15, 2020

Conversation

edwardmack
Copy link
Contributor

PR description

Change genesis config option ecip1099Block to thanosBlock based on comments PR1421

Fixed Issue(s)

Changelog

@edwardmack edwardmack requested a review from shemnon October 15, 2020 20:53
shemnon
shemnon approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few understand the meaning of this name.

@edwardmack
add changelog entry
a91c633 
Signed-off-by: Edward Mack <[email protected]>
@edwardmack edwardmack merged commit 2d7cdf0 into hyperledger:master Oct 15, 2020
@edwardmack edwardmack deleted the ed/etc_ecip1099Thanos branch October 15, 2020 21:56
shemnon pushed a commit to shemnon/besu that referenced this pull request Oct 19, 2020
@edwardmack @shemnon
rename genesis config option Ecip1099Block to ThanosBlock (hyperledge…
37b33a3 
…r#1462)

* rename genesis config option Ecip1099Block to ThanosBlock

Signed-off-by: Edward Mack <[email protected]>

* add changelog entry

Signed-off-by: Edward Mack <[email protected]>

(cherry picked from commit 2d7cdf0)
Signed-off-by: Danno Ferrin <[email protected]>
shemnon added a commit that referenced this pull request Oct 19, 2020
@shemnon @edwardmack
Cherry pick thanos (#1474)
3ae79e7 
* [ECIP-1099] Implement ECIP 1099: Calibrate Epoch Duration (#1421)
(cherry picked from commit 787871a)
Signed-off-by: Danno Ferrin <[email protected]>

* rename genesis config option Ecip1099Block to ThanosBlock (#1462)
(cherry picked from commit 2d7cdf0)
Signed-off-by: Danno Ferrin <[email protected]>

Co-authored-by: Edward Mack <[email protected]>
@shemnon shemnon added RC Backport PRs that need to be backported to the latest RC branch. Remove after backport. and removed RC Backport PRs that need to be backported to the latest RC branch. Remove after backport. labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardmack @shemnon