Ask block when not present #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <[email protected]>
matkt
changed the title
Signed-off-by: Karim TAAM <[email protected]>
matkt
force-pushed
the
feature/fix-missing-announced-block
branch
from
80499e7 to
325308b
Compare
RatanRSur
reviewed
Jun 28, 2021
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/BlockPropagationManager.java
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/BlockPropagationManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim TAAM <[email protected]>
RatanRSur
approved these changes
Jun 29, 2021
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…dger#2213) Signed-off-by: Karim TAAM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM [email protected]
PR description
Two nodes stopped importing this weekend. This PR is a fix candidate. The nodes were late and some blocks were not stored in the pending blocks cache (because there is a size limit with announced blocks). At the time of importing the missing block, Besu did not find the block and stopped; Here is my theory. So I implemented a mechanism that directly asks the missing blocks to peers in these cases
Fixed Issue(s)
Changelog