Remove shutdown latch from BftProcessor #3478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want BftMiningCoordinator.stop() to wait for BftProcessor to shutdown before calling shutdown on the BftExecutor. This prevents BftMiningCoordinator from being able to be shutdown from the same thread. We want to enable shutdown from the same thread to support migrating from one miningCoordinator instance to another (IBFT -> QBFT). Signed-off-by: Simon Dudley <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing this in favour of #3438 Although we probably don't need the latch for the 'shutdown besu' scenario, it doesn't fully solve the QBFT migration scenario. It was only worth risking this change if it was going to help resolve #3003 but I don't think it's possible to safely shutdown the bftProcessor/Executor from its own thread, we need another thread to manage this safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want BftMiningCoordinator.stop() to wait for BftProcessor to shutdown before calling shutdown on the BftExecutor.
This prevents BftMiningCoordinator from being able to be shutdown from the same thread.
We want to enable shutdown from the same thread to support migrating from one MiningCoordinator instance to another (IBFT -> QBFT).
This is the relevant discussion as to why the latch was originally added in: #104 (comment)
I believe the latch is unnecessary because BftExecutors.stop() (which calls bftProcessExecutor.shutdownNow) should be sufficient to safely prevent any further tasks from being accepted, whilst BftExecutors.awaitStop() (calling bftProcessExecutor.awaitTermination()) gives the current task(s) a chance to finish.
This PR is most if not all of the solution to #3003