Introduce virtual operation. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Evans <[email protected]> Signed-off-by: Abdelhamid Bakhta <[email protected]>
- add `isVirtualOperation` method to `Operation` interface: determines whether or not the operation has been virtually added to the contract code. - default implementation of `isVirtualOperation` returns `false` - create `VirtualOperation` that wraps a real `Operation` and returns `true` for `isVirtualOperation` method. - change `constructor` of `EVM` to pass a `GasCalculator` used to create the `endOfScriptStop` and `invalidOperation` fields. - change visibility of `EVM.operationAtOffset` to `package` for testing purpose. (add `VisibleForTesting` annotation) - create `EVMTest` to test `operationAtOffset` method . Signed-off-by: Abdelhamid Bakhta <[email protected]>
mbaxter
approved these changes
Sep 24, 2019
| @@ -1,2 +1,2 @@ | |||
| org.gradle.jvmargs=-Xmx1g | |||
| version=1.2.4 | |||
| version=1.2.5-SNAPSHOT | |||
There was a problem hiding this comment.
Looks like you have an extra commit here from Ed - can you remove this commit from your branch history?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Introduce
VirtualOperation.isVirtualOperationmethod toOperationinterface: determines whether or not the operation has been virtually added to the contract code.isVirtualOperationreturnsfalseVirtualOperationthat wraps a realOperationand returnstrueforisVirtualOperationmethod.constructorofEVMto pass aGasCalculatorused to create theendOfScriptStopandinvalidOperationfields.EVM.operationAtOffsettopackagefor testing purpose. (addVisibleForTestingannotation)EVMTestto testoperationAtOffsetmethod .Fixed Issue(s)