Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP 3860 #4742

Closed
wants to merge 6 commits into from
Closed

Implement EIP 3860 #4742

wants to merge 6 commits into from

Conversation

lukelee-sl
Copy link
Contributor

PR description

Implement EIP 3860

@lukelee-sl
Copy link
Contributor Author

@shemnon I don't seem to have the ability to set reviewers (or anything else)

@diega
Copy link
Contributor

diega commented Dec 1, 2022

Hello @lukelee-sl, do want you add your tests to #4726? I was about to merge that other one and then I found this implementation and your unit tests can be really useful.
As a review for this PR, I think we don't need to change the CREATE* operations to limit the size of the contracts b/c we already have a rule for that (check o.h.b.e.c.MaxCodeSizeRule). That's probably the main difference between the two PRs

@lukelee-sl
Copy link
Contributor Author

@diega Sure I'll have a go at adding my unit tests to #4726. Thanks for the review.

@diega
Copy link
Contributor

diega commented Dec 2, 2022

#4726 was merged with your changes. Would you want to close this one?

@lukelee-sl lukelee-sl closed this Dec 2, 2022
@lukelee-sl
Copy link
Contributor Author

Closing as this is implemented in #4726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukelee-sl @diega