Worldstate-only resync behavior #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
2 times, most recently
from
44a7cec to
7fd3377
Compare
|
@shemnon as far as UX for a resync feature, 'touching' a file in the data dir is rather simple to implement and accessible. A debug rpc endpoint may or may not be a good idea for this kind of functionality. What do you think about file vs rpc, file and rpc, or some other command pattern to trigger this behavior? |
|
I'm not a devops maven, I'd think we should get the UX feedback from someone who manages fleets of nodes. Touching a file feels hacky to me but I've discovered lots of DevOps "best practices" feel hacky to me. |
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
4 times, most recently
from
0a1ffae to
0346dad
Compare
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
from
39aa3a3 to
bf76408
Compare
matkt
previously requested changes
Jan 10, 2023
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/RpcMethod.java
Show resolved
Hide resolved
I'm no devops but I personally prefer an RPC call or a flag to a file that feels DIY. |
fab-10
approved these changes
Jan 10, 2023
Comment on lines
+52
to
+57
| public void reset() { | ||
| this.badBlocks.invalidateAll(); | ||
| this.badHeaders.invalidateAll(); | ||
| this.latestValidHashes.invalidateAll(); | ||
| } | ||
|
|
There was a problem hiding this comment.
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
2 times, most recently
from
bf59581 to
ee520db
Compare
garyschulte
dismissed
matkt’s stale review
As discussed oob, we will use debug namespace
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
from
ee520db to
8bb393e
Compare
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…ng on subsequent truncation at snap sync start Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…ndling during/after resync Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
garyschulte
force-pushed
the
feature/bonsai-resync-ws
branch
from
8bb393e to
d830f2a
Compare
siladu
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 7, 2023
* use debug rpc endpoint to resync worldstate * Reset transaction pool state every time the initial sync is done Signed-off-by: garyschulte <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
siladu
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 7, 2023
* use debug rpc endpoint to resync worldstate * Reset transaction pool state every time the initial sync is done Signed-off-by: garyschulte <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
Merged
jflo
added a commit
that referenced
this pull request
Feb 8, 2023
* Fix transaction pool issue (#4964) * Cache empty slots (#4874) * clear after each block and copy during clone * fix transaction pool issue * add block replay * support in-memory snapshots * Keep Worldstate Storage open for Bonsai archive latest layer (#5039) * bonsai layered worldstate subscription * unsubscribe from worldstatestorage on close of BonsaiLayeredWorldState * minor txpool logging improvements * Avoid triggering a calculate root hash when empty slot cache is not empty. * use the updater cache to get an account during block processing (#4897) * Worldstate-only resync behavior (#4875) * use debug rpc endpoint to resync worldstate * Reset transaction pool state every time the initial sync is done * init heal code --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* use debug rpc endpoint to resync worldstate * Reset transaction pool state every time the initial sync is done Signed-off-by: garyschulte <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implements a debug rpc endpoint and a behavior to resync just the worldstate.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog