Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-3162] Add versioned db acceptance tests #52

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Sep 25, 2019

PR description

Add acceptance tests that spin up a node from an existing database in various formats.

Previously you could set an expectation for a balance with a decimal
string value, but not a hex string value.  This was an error-prone
approach.

Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
@mbaxter mbaxter force-pushed the PAN-3162/add-versioned-db-acceptance-tests branch from 42e12cb to 72ddd6d Compare September 26, 2019 15:59
Signed-off-by: Meredith Baxter <[email protected]>
@mbaxter
Copy link
Contributor Author

mbaxter commented Oct 2, 2019

Closing this draft PR as it looks like this approach will not work. The database files contain data specific to the file system location where they were originally generated. We therefore can't simply generate some databases and copy them to a tmp folder for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant