-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAN-3162] Add versioned db acceptance tests #52
Closed
mbaxter
wants to merge
11
commits into
hyperledger:master
from
mbaxter:PAN-3162/add-versioned-db-acceptance-tests
Closed
[PAN-3162] Add versioned db acceptance tests #52
mbaxter
wants to merge
11
commits into
hyperledger:master
from
mbaxter:PAN-3162/add-versioned-db-acceptance-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Previously you could set an expectation for a balance with a decimal string value, but not a hex string value. This was an error-prone approach. Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
mbaxter
force-pushed
the
PAN-3162/add-versioned-db-acceptance-tests
branch
from
September 26, 2019 15:59
42e12cb
to
72ddd6d
Compare
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Closing this draft PR as it looks like this approach will not work. The database files contain data specific to the file system location where they were originally generated. We therefore can't simply generate some databases and copy them to a tmp folder for testing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add acceptance tests that spin up a node from an existing database in various formats.