Add world context to transaction tracing API #5836

delehef · 2023-09-01T08:00:48Z

PR description

Add world context to the start/end transaction hooks in the tracing API.

Fixed Issue(s)

fixes: #5835

github-actions · 2023-09-01T08:00:59Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

delehef · 2023-09-01T08:11:01Z

ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/T8nExecutor.java

@@ -270,6 +270,7 @@ static T8nResult runTest(
      final TransactionProcessingResult result;
      try {
        tracer = tracerManager.getManagedTracer(i, transaction.getHash());
+        tracer.traceStartTransaction(worldStateUpdater, transaction);


I am not sure why the tracer was not called here previously?

it seems you added the traceEndTransaction @diega . do you know if it's normal to not have the startTransaction ?

Yes, it looks like it was needed. I never used the --json|--trace flag from the t8n tool, so I cannot say if/how it was working without the tracer start. Probably @shemnon can confirm it

It feels like this should be called somewhere in MainnetTransactionProcessor.processTransaction rather than as part of the lead-up.

same with endTransaction.

@shemnon given that gasUsed can't be computed from within processTransaction, that implies to either:

dirty processTransaction signature to pass gasUsed only for the sake of tracing;

just drop gasUsed from the traceEndTransaction API.

What do you think?

evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

   * @param transaction the transaction which will be processed
   */
-  default void traceStartTransaction(final Transaction transaction) {}
+  default void traceStartTransaction(final WorldView worldView, final Transaction transaction) {}


evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

   * @param transaction the transaction which will be processed
   */
-  default void traceStartTransaction(final Transaction transaction) {}
+  default void traceStartTransaction(final WorldView worldView, final Transaction transaction) {}


matkt · 2023-09-01T12:38:13Z

could you explain how you will use this updater. I don't think it's a good idea to pass the worldUpdater to the trace object. I think you want to use this worldUpdater later in order to retrieve some account or other data.

in bonsai you have a huge risk that this objet will be a closed snapshot and it will not work . I you need a specific data from this updater I think it's better to take it directly and pass the value to the trace object

matkt · 2023-09-01T13:15:09Z

could you explain how you will use this updater. I don't think it's a good idea to pass the worldUpdater to the trace object. I think you want to use this worldUpdater later in order to retrieve some account or other data.

in bonsai you have a huge risk that this objet will be a closed snapshot and it will not work . I you need a specific data from this updater I think it's better to take it directly and pass the value to the trace object

ok we did a check and it's fine regarding that .

matkt

LGTM for me it's ok but I waiting for @diega regarding T8nExecutor class and maybe @shemnon

evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

macfarla · 2023-09-06T04:17:23Z

@diega @shemnon any objections to this approach?

diega · 2023-09-07T13:47:37Z

What's the practical use of this change? is there some other PR giving more context on why is this new interface needed?

shemnon

I want to see some tests for this. They can be unit tests, or the full JSON tests using the T8n spec tracer, but I would like to have some output verified so that if the call to trace methods get moved around incorrectly or removed something breaks as part of the build.

delehef · 2023-09-08T09:30:17Z

What's the practical use of this change?

This change is part of a larger set of changes that are helping in the development of the Linea project.

evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

   * @param gasUsed the gas used by the entire transaction
   * @param timeNs the time in nanoseconds it took to execute the transaction
   */
-  default void traceEndTransaction(final Bytes output, final long gasUsed, final long timeNs) {}
+  default void traceEndTransaction(
+      final WorldView worldView,


evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

-  default void traceEndTransaction(final Bytes output, final long gasUsed, final long timeNs) {}
+  default void traceEndTransaction(
+      final WorldView worldView,
+      final Transaction tx,


evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

+  default void traceEndTransaction(
+      final WorldView worldView,
+      final Transaction tx,
+      final boolean status,


evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java

+      final Transaction tx,
+      final boolean status,
+      final Bytes output,
+      final List<Log> logs,


Signed-off-by: Franklin Delehelle <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>

--- Drop Kotti Network support (ETC) (hyperledger#5816) Signed-off-by: Diego López León <[email protected]> fix ForkId if there are no Forks and the starting timestamp is not 0 (hyperledger#5819) Signed-off-by: Stefan <[email protected]> enforce that BlobTransactions have at least one blob (hyperledger#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Do not create ignorable segments on `revert storage-variables` (hyperledger#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> add versioned hashes and number of blobs to toString() (hyperledger#5831) Signed-off-by: Stefan <[email protected]> add parent beacon block root to payload id calculation (hyperledger#5843) Signed-off-by: Stefan <[email protected]> bump version to 23.7.3-SNAPSHOT (hyperledger#5854) Signed-off-by: Daniel Lehrner <[email protected]> set the beacon root address to the correct value (hyperledger#5853) Signed-off-by: Stefan <[email protected]> docs(readme): fix broken link to installation of binaries page (hyperledger#5859) Fixes hyperledger#5858 Signed-off-by: Peter Somogyvari <[email protected]> Update RocksDB version from 8.0.0 to 8.3.2 (hyperledger#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> use non-deprecated authenticate methods (hyperledger#5852) Signed-off-by: Sally MacFarlane <[email protected]> move to Hyperledger shared runners for current github actions (hyperledger#5860) Signed-off-by: garyschulte <[email protected]> Add range tracing with worldstate (hyperledger#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Layered txpool by default and txpool options hoverhaul (hyperledger#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (hyperledger#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> updated gradle verification metadata (hyperledger#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Stefan <[email protected]> payload attributes: fix wrong warning and fail if beacon root is available before cancun (hyperledger#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Merge MutableAccount and EVMAccount (hyperledger#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Add world context to transaction tracing API (hyperledger#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Bonsai based reference test worldstate (hyperledger#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Don't start BFT mining coordinators until initial sync has completed (hyperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> display only peers ready for requets on ethstats (hyperledger#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> [MINOR] test RLP used for encode/decode blob tx should contain to field (hyperledger#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Fix: correctly convert percentage options in TOML configuration file (hyperledger#5886) Signed-off-by: Fabio Di Fabio <[email protected]> EIP7516 - Add BlobBaseFee opcode to Cancun EVM (hyperledger#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Fix snapsync heal (hyperledger#5838) Signed-off-by: Karim TAAM <[email protected]> Upgrade besu-native (hyperledger#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Tune G1GC to reduce Besu memory footprint (hyperledger#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Add updated storage to evmtool json trace (hyperledger#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Update holesky with fixed extraData, genesis time, shanghaiTime (hyperledger#5890) Signed-off-by: Simon Dudley <[email protected]> [CHANGELOG] removed duplicated line (hyperledger#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>

* Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

* Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]>

* Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

burn-in candidate for 23.7.3 from main sha 6dc10a9..eef40bd https://github.com/hyperledger/besu/compare/6dc10a9..eef40bd --- * Drop Kotti Network support (ETC) (#5816) Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> * fix ForkId if there are no Forks and the starting timestamp is not 0 (#5819) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * enforce that BlobTransactions have at least one blob (#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * Do not create ignorable segments on `revert storage-variables` (#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <[email protected]> * add versioned hashes and number of blobs to toString() (#5831) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * add parent beacon block root to payload id calculation (#5843) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * bump version to 23.7.3-SNAPSHOT (#5854) Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: garyschulte <[email protected]> * set the beacon root address to the correct value (#5853) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * docs(readme): fix broken link to installation of binaries page (#5859) Fixes #5858 Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update RocksDB version from 8.0.0 to 8.3.2 (#5832) Signed-off-by: Ameziane H <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * use non-deprecated authenticate methods (#5852) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * move to Hyperledger shared runners for current github actions (#5860) Signed-off-by: garyschulte <[email protected]> * Add range tracing with worldstate (#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Layered txpool by default and txpool options hoverhaul (#5772) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <[email protected]> Signed-off-by: garyschulte <[email protected]> * updated gradle verification metadata (#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * #5868: fix beacon root address and modulus for devnet 9 (#5871) Signed-off-by: Stefan <[email protected]> Signed-off-by: garyschulte <[email protected]> * payload attributes: fix wrong warning and fail if beacon root is available before cancun (#5872) Signed-off-by: Stefan <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Merge MutableAccount and EVMAccount (#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add world context to transaction tracing API (#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Bonsai based reference test worldstate (#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Don't start BFT mining coordinators until initial sync has completed (#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <[email protected]> * Fix unit tests Signed-off-by: Matthew Whitehead <[email protected]> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: garyschulte <[email protected]> * display only peers ready for requets on ethstats (#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <[email protected]> * cast to int Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: garyschulte <[email protected]> * [MINOR] test RLP used for encode/decode blob tx should contain to field (#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <[email protected]> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix: correctly convert percentage options in TOML configuration file (#5886) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * EIP7516 - Add BlobBaseFee opcode to Cancun EVM (#5884) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: garyschulte <[email protected]> * Fix snapsync heal (#5838) Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: garyschulte <[email protected]> * Upgrade besu-native (#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Tune G1GC to reduce Besu memory footprint (#5879) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: garyschulte <[email protected]> * Add updated storage to evmtool json trace (#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: garyschulte <[email protected]> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: garyschulte <[email protected]> * [CHANGELOG] removed duplicated line (#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <[email protected]> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> * add 23.7.2 release SHAs and bump to 23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-RC version Signed-off-by: garyschulte <[email protected]> --------- Signed-off-by: Diego López León <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Diego López León <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Peter Somogyvari <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]>

* Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <[email protected]> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <[email protected]> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <[email protected]> * Rebase on main Signed-off-by: Franklin Delehelle <[email protected]> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <[email protected]> * added test Signed-off-by: Daniel Lehrner <[email protected]> --------- Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>

delehef commented Sep 1, 2023

View reviewed changes

github-advanced-security bot found potential problems Sep 1, 2023

View reviewed changes

matkt reviewed Sep 1, 2023

View reviewed changes

github-advanced-security bot found potential problems Sep 5, 2023

View reviewed changes

evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Fixed Show fixed Hide fixed

evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Fixed Show fixed Hide fixed

matkt approved these changes Sep 7, 2023

View reviewed changes

matkt enabled auto-merge (squash) September 7, 2023 13:42

shemnon suggested changes Sep 7, 2023

View reviewed changes

delehef requested a review from shemnon September 12, 2023 16:01

auto-merge was automatically disabled September 12, 2023 18:57
Head branch was pushed to by a user without write access

github-advanced-security bot found potential problems Sep 13, 2023

View reviewed changes

delehef and others added 6 commits September 13, 2023 15:58

Add world context to transaction tracing API

77ead99

Signed-off-by: Franklin Delehelle <[email protected]>

Update changelog with PR ID

6e69e75

Signed-off-by: Franklin Delehelle <[email protected]>

Add the Transaction to traceEndTransaction

b560bc3

Signed-off-by: Franklin Delehelle <[email protected]>

Rebase on main

166fb6b

Signed-off-by: Franklin Delehelle <[email protected]>

Add receipt-linked information to the transaction tracer

38bcfe5

Signed-off-by: Franklin Delehelle <[email protected]>

added test

46b11e8

Signed-off-by: Daniel Lehrner <[email protected]>

shemnon approved these changes Sep 14, 2023

View reviewed changes

Merge branch 'main' into feat/issue-5835/tracing-tx-context

6a96757

macfarla enabled auto-merge (squash) September 14, 2023 02:27

macfarla merged commit 3538561 into hyperledger:main Sep 14, 2023

siladu mentioned this pull request Sep 20, 2023

Burn in release of 23.7.3 from main (inclusive of sha eef40bd) #5905

Closed

delehef deleted the feat/issue-5835/tracing-tx-context branch September 26, 2023 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add world context to transaction tracing API #5836

Add world context to transaction tracing API #5836

delehef commented Sep 1, 2023

github-actions bot commented Sep 1, 2023

delehef Sep 1, 2023

matkt Sep 1, 2023

diega Sep 1, 2023

shemnon Sep 7, 2023 •

edited

Loading

shemnon Sep 7, 2023

delehef Sep 8, 2023

matkt commented Sep 1, 2023

matkt commented Sep 1, 2023

matkt left a comment

macfarla commented Sep 6, 2023

diega commented Sep 7, 2023

shemnon left a comment

delehef commented Sep 8, 2023

Add world context to transaction tracing API #5836

Add world context to transaction tracing API #5836

Conversation

delehef commented Sep 1, 2023

PR description

Fixed Issue(s)

github-actions bot commented Sep 1, 2023

delehef Sep 1, 2023

Choose a reason for hiding this comment

matkt Sep 1, 2023

Choose a reason for hiding this comment

diega Sep 1, 2023

Choose a reason for hiding this comment

shemnon Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

shemnon Sep 7, 2023

Choose a reason for hiding this comment

delehef Sep 8, 2023

Choose a reason for hiding this comment

matkt commented Sep 1, 2023

matkt commented Sep 1, 2023

matkt left a comment

Choose a reason for hiding this comment

macfarla commented Sep 6, 2023

diega commented Sep 7, 2023

shemnon left a comment

Choose a reason for hiding this comment

delehef commented Sep 8, 2023

shemnon Sep 7, 2023 •

edited

Loading