-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plugin API to enable plugins to validate transaction before they are added to the transaction pool #5891
Merged
macfarla
merged 13 commits into
hyperledger:main
from
pinges:TransactionValidatorService
Sep 25, 2023
Merged
add plugin API to enable plugins to validate transaction before they are added to the transaction pool #5891
macfarla
merged 13 commits into
hyperledger:main
from
pinges:TransactionValidatorService
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are added to the transaction pool Signed-off-by: Stefan <[email protected]>
|
Signed-off-by: Stefan <[email protected]>
macfarla
reviewed
Sep 22, 2023
besu/src/main/java/org/hyperledger/besu/services/TransactionValidatorServiceImpl.java
Outdated
Show resolved
Hide resolved
plugin-api/src/main/java/org/hyperledger/besu/plugin/services/TransactionValidatorService.java
Outdated
Show resolved
Hide resolved
plugin-api/src/main/java/org/hyperledger/besu/plugin/services/TransactionValidatorService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan <[email protected]>
Signed-off-by: Stefan <[email protected]>
Signed-off-by: Stefan <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
…into TransactionValidatorService
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
…are added to the transaction pool (hyperledger#5891) * add plugin API to enable plugins to validate transaction before they are added to the transaction pool Signed-off-by: Stefan <[email protected]> * updated plugin version Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Stefan <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
…are added to the transaction pool (hyperledger#5891) * add plugin API to enable plugins to validate transaction before they are added to the transaction pool Signed-off-by: Stefan <[email protected]> * updated plugin version Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Stefan <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adding a plugin API to enable plugins to validate of transactions entering the transaction pool