Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Block number param additional test #5918

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[MINOR] Block number param additional test #5918

merged 2 commits into from
Sep 21, 2023

Conversation

macfarla
Copy link
Contributor

Just an additional test to prove that hex and binary are both supported at this level

@macfarla
add test for hex vs decimal block parameter
537c5db 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
typo
be46b41 
Signed-off-by: Sally MacFarlane <[email protected]>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla enabled auto-merge (squash) September 21, 2023 06:35
@macfarla macfarla merged commit 277424d into hyperledger:main Sep 21, 2023
@macfarla macfarla deleted the block-number-param-additional-test branch September 24, 2023 23:22
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
@macfarla @jflo
[MINOR] Block number param additional test (hyperledger#5918)
09eaad6 
* add test for hex vs decimal block parameter

Signed-off-by: Sally MacFarlane <[email protected]>

* typo

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
@macfarla @NickSneo
[MINOR] Block number param additional test (hyperledger#5918)
ecf2368 
* add test for hex vs decimal block parameter

Signed-off-by: Sally MacFarlane <[email protected]>

* typo

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @shemnon