[4844] [Hive] Fix fcuV3 parameter return #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
|
Gabriel-Trintinalia
changed the title
macfarla
approved these changes
Sep 26, 2023
| if (fcuParameter.getHeadBlockHash() == null) { | ||
| return ValidationResult.invalid(RpcErrorType.INVALID_PARAMS, "Missing head block hash"); | ||
| } else if (fcuParameter.getSafeBlockHash() == null) { | ||
| return ValidationResult.invalid(RpcErrorType.INVALID_PARAMS, "Missing safe block hash"); | ||
| } else if (fcuParameter.getFinalizedBlockHash() == null) { | ||
| return ValidationResult.invalid(RpcErrorType.INVALID_PARAMS, "Missing finalized block hash"); | ||
| } | ||
| if (maybePayloadAttributes.isPresent()) { |
There was a problem hiding this comment.
this is the parameter checking you mean that will potentially conflict with the larger refactor?
There was a problem hiding this comment.
I think fine to fix it like this in the short-term to clear the noise for the hive tests
There was a problem hiding this comment.
We would not necessarily have to validate this if the plans are to use strict JSON validation
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix some hive tests