Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated beacon root and modulus to match DRAFT eip #5941

Merged
merged 1 commit into from
Sep 26, 2023
Merged

updated beacon root and modulus to match DRAFT eip #5941

merged 1 commit into from
Sep 26, 2023

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Sep 26, 2023 •
edited
Loading

Still draft but this time it says final ethereum/EIPs#7672 (comment)

Also renamed the modulus value so it matches the name used in the EIP

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla
Copy link
Contributor Author

last updated here #5903

@jflo jflo marked this pull request as ready for review September 26, 2023 15:43
@jflo
Copy link
Contributor

jflo commented Sep 26, 2023

I'm doing it again!

@jflo jflo merged commit 3afd3ca into hyperledger:main Sep 26, 2023
Shritesh99 pushed a commit to Shritesh99/besu that referenced this pull request Sep 27, 2023
@macfarla @Shritesh99
updated beacon root and modulus to match DRAFT eip (hyperledger#5941)
48d42e9 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Shritesh <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
@macfarla @jflo
updated beacon root and modulus to match DRAFT eip (hyperledger#5941)
1ca5ca0 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
@macfarla @NickSneo
updated beacon root and modulus to match DRAFT eip (hyperledger#5941)
8add14a 
Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @jflo