Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction pool unit tests refactoring to remove duplicated code #5948

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Sep 26, 2023

PR description

Refactor transaction pool tests to remove all the duplicated code that was introduced when implementing the layered txpool.
Now all tests are defined in AbstractTransactionPoolTest and extending classes are used to setup the right env for fee market and txpool implementation.
This make the tests more future proof, since in this way a new test is run against all the implementations and fee markets, while before you had to remember to code the test twice.

@fab-10 fab-10 changed the title Transaction pool unit tests refactoring to remove duplications Transaction pool unit tests refactoring to remove duplicated code Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 marked this pull request as ready for review September 26, 2023 17:10
@fab-10 fab-10 force-pushed the txpool-test-refactor branch from 583c5b9 to f4e04a2 Compare September 26, 2023 17:29
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 enabled auto-merge (squash) September 27, 2023 06:52
@fab-10 fab-10 merged commit 84023d8 into hyperledger:main Sep 27, 2023
@fab-10 fab-10 deleted the txpool-test-refactor branch September 27, 2023 07:49
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants