Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] ux improvements #6049

Merged
merged 11 commits into from
Oct 19, 2023
Merged

[MINOR] ux improvements #6049

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af14c84
log at info
macfarla Oct 18, 2023
cbe19cb
typo
macfarla Oct 18, 2023
db5c65f
log command line option that is affected
macfarla Oct 18, 2023
027afff
Merge branch 'main' of github.com:hyperledger/besu into plugins-ux
macfarla Oct 18, 2023
0542fdb
Merge branch 'main' of github.com:hyperledger/besu into plugins-ux
macfarla Oct 18, 2023
77cbec7
made plugins summary log part of config overview
macfarla Oct 19, 2023
d2c96d8
Merge branch 'main' of github.com:hyperledger/besu into plugins-ux
macfarla Oct 19, 2023
4c43d53
debug lvl for one remaining msg
macfarla Oct 19, 2023
cddf542
javadoc
macfarla Oct 19, 2023
ccef082
formatting
macfarla Oct 19, 2023
d2943ba
check for null plugin context
macfarla Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions besu/src/main/java/org/hyperledger/besu/cli/util/CommandLineUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public static void checkMultiOptionDependencies(
}

/**
* Fail if option doesnt meet requirement.
* Fail if option doesn't meet requirement.
*
* @param commandLine the command line
* @param errorMessage the error message
Expand All @@ -126,7 +126,8 @@ public static void failIfOptionDoesntMeetRequirement(
final String affectedOptions = getAffectedOptions(commandLine, dependentOptionsNames);

if (!affectedOptions.isEmpty()) {
throw new CommandLine.ParameterException(commandLine, errorMessage);
throw new CommandLine.ParameterException(
commandLine, errorMessage + " [" + affectedOptions + "]");
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ public void registerPlugins(final Path pluginsDir) {
plugins.add(plugin);
}

LOG.debug("Plugin registration complete.");
LOG.info("Plugin registration complete.");
lines.add("");
lines.add("TOTAL = " + plugins.size());
LOG.debug(FramedLogMessage.generate(lines));
LOG.info(FramedLogMessage.generate(lines));

state = Lifecycle.REGISTERED;
}
Expand Down
2 changes: 1 addition & 1 deletion besu/src/main/java/org/hyperledger/besu/services/RpcEndpointServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import java.util.function.Function;
import java.util.stream.Collectors;

/** The Rpc endpoint service implementation. */
/** The RPC endpoint service implementation. */
public class RpcEndpointServiceImpl implements RpcEndpointService {
private final Map<String, Function<PluginRpcRequest, ?>> rpcMethods = new HashMap<>();

Expand Down
Loading