Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus/common migrate to junit5 #6233

Closed
wants to merge 12 commits into from
Closed

consensus/common migrate to junit5 #6233

wants to merge 12 commits into from

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 5, 2023

fixes #5569

@macfarla
migrate to junit5
e69ac81 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla changed the title consensys/common migrate to junit5 consensus/common migrate to junit5 Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

jframe
jframe approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla mentioned this pull request Dec 7, 2023
Merged
@macfarla
Copy link
Contributor Author

macfarla commented Dec 7, 2023

closing in favour of #6253

@macfarla macfarla closed this Dec 7, 2023
@macfarla macfarla deleted the common-junit-5 branch December 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consensus - migrate tests from Junit4 to Junit5
4 participants
@macfarla @jframe @delehef @garyschulte