Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split acceptance tests by time #6953

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Apr 15, 2024

PR description

Was looking at why our ATs are not correctly split by time, and found that the action that we are using is based on a tool, that requires a special XML report with additional attributes, so as fallback the split is just done by name, this PR implements the split by time using a custom shell script

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the split-ats-by-time branch 9 times, most recently from 4264211 to a1ce0a4 Compare April 15, 2024 16:21
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 force-pushed the split-ats-by-time branch from a1ce0a4 to 657f69e Compare April 15, 2024 16:23
@fab-10 fab-10 marked this pull request as ready for review April 15, 2024 16:27
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 enabled auto-merge (squash) April 16, 2024 08:43
@fab-10 fab-10 merged commit 941ab01 into hyperledger:main Apr 16, 2024
42 checks passed
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: amsmota <[email protected]>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: amsmota <[email protected]>
macfarla pushed a commit to macfarla/besu that referenced this pull request Apr 26, 2024
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@fab-10 fab-10 deleted the split-ats-by-time branch November 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants