Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build - Upgrade to Gradle 8 #7052

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

usmansaleem
Copy link
Member

@usmansaleem usmansaleem commented May 6, 2024

PR description

build - Upgrade to Gradle 8.7
build - Upgrade web3j plugin to 4.11.3 (used in Acceptance tests)

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@usmansaleem usmansaleem marked this pull request as ready for review May 6, 2024 02:30
@usmansaleem usmansaleem enabled auto-merge (squash) May 6, 2024 02:36
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we see if the gradle wrapper task wanted to update the shell scripts?

@usmansaleem usmansaleem merged commit c63f415 into hyperledger:main May 6, 2024
42 checks passed
@usmansaleem
Copy link
Member Author

Did we see if the gradle wrapper task wanted to update the shell scripts?

@shemnon I ran ./gradlew wrapper --gradle-version=8.7 --distribution-type=bin. The command didn't upgrade the shell scripts. Probably due to earlier upgrade to 7.6.4. #7030

@usmansaleem usmansaleem deleted the gradle_8 branch May 6, 2024 06:31
@non-fungible-nelson
Copy link
Contributor

Not sure if these are related, some bug reports:

from my own installDist on main:

Configure project :
Generating project version as supplied is version not semver: unspecified

FAILURE: Build failed with an exception.

  • Where:
    Build file '/Users/matt.nelson/dev/mainnet/besu/ethereum/referencetests/build.gradle' line: 239

  • What went wrong:
    Could not determine the dependencies of task ':installDist'.

Could not resolve all dependencies for configuration ':runtimeClasspath'.
Could not create task ':ethereum:referencetests:executionSpecTests'.
> /Users/matt.nelson/dev/mainnet/besu/ethereum/referencetests/src/reference-test/templates/BlockchainReferenceTest.java.template


From Seamonkey:
➜ besu git:(main) ./gradlew distTar installDist

Configure project :
Generating project version as supplied is version not semver: unspecified

Task :installDist FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem was found with the configuration of task ':installDist' (type 'Sync').
    • Gradle detected a problem with the following location: '/home/seamonkey/Downloads/holesky/besu/build/besu.autocomplete.sh'.

      Reason: Task ':installDist' uses this output of task ':autocomplete' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

Commithash: 45b6c08

jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
* build - Upgrade gradle to 8.7
* build - Upgrade web3j plugin to 4.11.3
* build - Update gradle verification-metadata.xml

---------

Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* build - Upgrade gradle to 8.7
* build - Upgrade web3j plugin to 4.11.3
* build - Update gradle verification-metadata.xml

---------

Signed-off-by: Usman Saleem <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
* build - Upgrade gradle to 8.7
* build - Upgrade web3j plugin to 4.11.3
* build - Update gradle verification-metadata.xml

---------

Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants