Split unit tests by time #7079
Merged
Split unit tests by time #7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
split-unit-tests-by-time
branch
19 times, most recently
from
2d2fe15 to
9594188
Compare
fab-10
force-pushed
the
split-unit-tests-by-time
branch
5 times, most recently
from
de93355 to
758c66f
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
split-unit-tests-by-time
branch
4 times, most recently
from
d94aa8d to
3d5314c
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
split-unit-tests-by-time
branch
from
283b2c4 to
55c52e2
Compare
macfarla
reviewed
May 20, 2024
macfarla
approved these changes
May 21, 2024
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]>
there should be no difference in that |
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
* Split unit tests by time Signed-off-by: Fabio Di Fabio <[email protected]> * Parallelize compile and unit tests since there is not shared cache Signed-off-by: Fabio Di Fabio <[email protected]> * fix Signed-off-by: Fabio Di Fabio <[email protected]> * Reduce ATs runnes to 10 Signed-off-by: Fabio Di Fabio <[email protected]> * Apply suggestions from code review Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
* Split unit tests by time Signed-off-by: Fabio Di Fabio <[email protected]> * Parallelize compile and unit tests since there is not shared cache Signed-off-by: Fabio Di Fabio <[email protected]> * fix Signed-off-by: Fabio Di Fabio <[email protected]> * Reduce ATs runnes to 10 Signed-off-by: Fabio Di Fabio <[email protected]> * Apply suggestions from code review Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR reduces the time of the
pre-reviewworkflow from ~30min to <20min, splitting unit tests by time, and removing the dependency betweencompileandunit testssince the Gradle cache is disabled and so test tasks need to recompile anyway.Also reduced the number of ATs runners to 10 since the workflow takes only ~10min to complete.
Next step is to see if reference tests can be split by time as well.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests