Minor improvements to EIP-7685 #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia
changed the title
macfarla
approved these changes
May 27, 2024
| /** | ||
| * Combines two optional lists of requests into a single optional list. | ||
| * | ||
| * @param maybeDeposits Optional list of deposit requests. |
There was a problem hiding this comment.
nit - for consistency should this be renamed to maybeDepositsRequest
There was a problem hiding this comment.
actually on further consideration I see that matches the class names Deposit and WithdrawalRequest
There was a problem hiding this comment.
We have Withdrawal and WithdrawalRequest but Deposit is itself the request... it is a bit confusing but probably outside the scope of this PR. non-blocking.
There was a problem hiding this comment.
I will rename Deposit to DepositRequest but I wanted to do that in a different PR so it is easier to review it.
jframe
approved these changes
May 28, 2024
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Address feedback of #7068