Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust text so it succeeds on macOS #7328

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

macfarla
Copy link
Contributor

PR description

LoggingTest AT failing on Mac because of weird separators

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla closed this Jul 16, 2024
@macfarla macfarla deleted the logging-test-mod branch July 16, 2024 05:58
@macfarla macfarla restored the logging-test-mod branch July 16, 2024 23:25
@macfarla macfarla reopened this Jul 16, 2024
@macfarla macfarla merged commit d03c5b6 into hyperledger:main Jul 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants