Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GeneralStateTestCaseEipSpec for use in linea-arithmetization #7377

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

gauravahuja
Copy link
Contributor

PR description

In linea arithmetization we are updating unit tests to use the GeneralStateTestCaseEipSpec for testing. For that I need to

  1. Update the constructor to public so that it can be instantiated in other packages.
  2. Include multiple transactions as we have unit tests that test multiple transactions.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@gauravahuja gauravahuja force-pushed the update_general_test_case_spec branch from 920c2b3 to 6e8a5ef Compare July 25, 2024 08:28
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla enabled auto-merge (squash) July 25, 2024 21:52
@macfarla macfarla merged commit cf358c0 into hyperledger:main Jul 25, 2024
40 checks passed
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
…yperledger#7377)

* Update GeneralStateTestCaseEipSpec for use in linea-arithmetization

Signed-off-by: Gaurav Ahuja <[email protected]>

* formatting

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Gaurav Ahuja <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: gconnect <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants