Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default --help values #7454

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

7suyash7
Copy link
Contributor

Fixes #7367 : Correct default value display for --rpc-max-trace-filter-range along with the requested unit test.

Fixes #7369 : Show default value for --genesis-state-hash-cache-enabled.

@7suyash7 7suyash7 force-pushed the fix-help-default-values-clean branch from d4c5514 to e232b06 Compare August 13, 2024 13:20
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Tested this locally and it's now displaying the default values correctly

@jframe jframe enabled auto-merge (squash) August 14, 2024 04:45
@jframe jframe merged commit adf19af into hyperledger:main Aug 14, 2024
40 checks passed
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
* Fix hyperledger#7367: Correct default value display for --rpc-max-trace-filter-range along with a test
* Fix hyperledger#7369: Show default value for --genesis-state-hash-cache-enabled

Signed-off-by: 7suyash7 <[email protected]>
Signed-off-by: gconnect <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants