5098 branch 22 update more invalid params #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <[email protected]>
…ion, apply spotless Signed-off-by: Matilda Clerke <[email protected]>
…ion, apply spotless Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ounts-params' into 5098-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
Signed-off-by: Matilda Clerke <[email protected]>
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
…ss-blob-gas-params' into 5098-branch-17-update-extra-data-and-filter-params
…params' into 5098-branch-18-update-more-invalid-params
…nto 5098-branch-19-update-more-invalid-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…nto 5098-branch-22-update-more-invalid-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…id-params' into 5098-branch-22-update-more-invalid-params
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
approved these changes
Aug 19, 2024
| transactionHash = requestContext.getRequiredParameter(0, Hash.class); | ||
| } catch (Exception e) { // TODO:replace with JsonRpcParameter.JsonRpcParameterException | ||
| throw new InvalidJsonRpcParameters( | ||
| "Invalid transaction has parameter (index 0)", |
There was a problem hiding this comment.
Suggested change
| "Invalid transaction has parameter (index 0)", | |
| "Invalid transaction hash parameter (index 0)", |
| .orElse(TraceOptions.DEFAULT); | ||
| } catch (Exception e) { // TODO:replace with JsonRpcParameter.JsonRpcParameterException | ||
| throw new InvalidJsonRpcParameters( | ||
| "Invalid transaction trace parameters (index 1)", |
There was a problem hiding this comment.
Suggested change
| "Invalid transaction trace parameters (index 1)", | |
| "Invalid transaction trace parameter (index 1)", |
| .orElse(TraceOptions.DEFAULT); | ||
| } catch (Exception e) { // TODO:replace with JsonRpcParameter.JsonRpcParameterException | ||
| throw new InvalidJsonRpcParameters( | ||
| "Invalid transaction trace parameters (index 2)", |
There was a problem hiding this comment.
Suggested change
| "Invalid transaction trace parameters (index 2)", | |
| "Invalid transaction trace parameter (index 2)", |
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 23, 2024
* 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
* 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update remaining RpcErrorTypes
Fixed Issue(s)
#5098