Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoW mining - deprecation #7905

Merged
merged 9 commits into from
Nov 29, 2024
Merged

PoW mining - deprecation #7905

merged 9 commits into from
Nov 29, 2024

Conversation

macfarla
Copy link
Contributor

PR description

Deprecation notices in help; log message if mining is enabled; @Deprecation annotations on mining RPC methods

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla marked this pull request as draft November 25, 2024 01:21
@macfarla macfarla marked this pull request as ready for review November 27, 2024 23:10
@fab-10 fab-10 mentioned this pull request Nov 28, 2024
8 tasks
@macfarla macfarla enabled auto-merge (squash) November 28, 2024 22:05
@macfarla macfarla merged commit 792c656 into hyperledger:main Nov 29, 2024
43 checks passed
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 2, 2024
@macfarla macfarla deleted the pow-dep branch December 5, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants