EIP-7623 #7997

daniellehrner · 2024-12-07T18:57:56Z

PR description

Implementation of EIP-7623

The PR refactors the calculation of intrinsic gas. For 7623 the intrinsic gas calculation needs to be aware of the intrinsic costs for setting code delegations and access lists. Those values and any future values are passed to the gas calculation via the parameter evmGasUsed.

The PR splits the intrinsic gas calculation into three steps:

call data gas calculation
code creation gas calculation
evmGasUsed

Further all the additions in the calculation are done with the clampedAdd method to handle over- or underflows correctly.

Known issues:

Reference tests for Prague are failing, which is to be expected, because those have been created without 7623 in mind
7623 calculation need further testing once execution spec test are ready
Unit test are still missing

Fixed Issue(s)

fixes #7994

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

daniellehrner · 2024-12-07T18:59:06Z

evm/src/main/java/org/hyperledger/besu/evm/gascalculator/GasCalculator.java

-   * @return the maximum gas cost
-   */
-  // what would be the gas for a PMT with hash of all non-zeros
-  long getMaximumTransactionCost(int size);


This method is unused, the deletion is a simply cleanup and not related to any other refactoring.

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java

* Change the output log on newPayload and FCU executions Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…edger#7993) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>

Update CHANGELOG.md for 24.12.0 release Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>

* Update EOFCREATE memory code Switch to longs so EOFCREATE can handle gigagas sized transactions. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>

…ger#8001) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…s in the release checklist (hyperledger#8004) Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…dger#6646) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken BesuCommandTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: add class Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move PeerTaskFeatureToggle to more appropriate location Signed-off-by: Matilda Clerke <[email protected]> * 7311: add X prefix to peertask-system-enabled Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move --Xpeertask-system-enabled out of BesuCommand and make hidden Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add GetReceiptsFromPeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move isPeerTaskSystemEnabled to SynchronizerOptions Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix javadoc issue Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix javadoc issue Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move PeerTaskFeatureToggleTestHelper to TestUtil and fix RunnerTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove PeerTaskFeatureToggle in favor of including isPeerTaskSystemEnabled in SynchronizerConfiguration Signed-off-by: Matilda Clerke <[email protected]> * 7311: Adjust to the removal of PeerTaskFeatureToggle and use SynchronizerConfiguration to get the toggle instead Signed-off-by: Matilda Clerke <[email protected]> * 7311: Reduce timeout in PeerTaskRequestSender to 5s Signed-off-by: Matilda Clerke <[email protected]> * 7311: Refactor PeerManager to be an interface Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up compile errors after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix DownloadReceiptsStep when using peer task system Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rename PeerManager to PeerSelector Signed-off-by: Matilda Clerke <[email protected]> * 7311: Reword PeerSelector javadoc to avoid implementation details Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use ConcurrentHashMap in DefaultPeerSelector Signed-off-by: Matilda Clerke <[email protected]> * 7311: Reword trace log in DefaultPeerSelector Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove unused imports Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use a 1 second delay between retries in PeerTaskExecutor to match old implementation Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add testGetPeerButNoPeerMatchesFilter to DefaultPeerSelectorTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add testGetPeerButNoPeerMatchesFilter to DefaultPeerSelectorTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix MetricsAcceptanceTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Modify PeerTaskExecutor metric to include response time from peer Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use SubProtocol instead of subprotocol name string in PeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: rename timing context to ignored to prevent intellij warnings Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use constants for number of retries Signed-off-by: Matilda Clerke <[email protected]> * 7311: Convert PeerTaskExecutorResult to a record Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rename PeerTaskBehavior to PeerTaskRetryBehavior Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move peer selection logic to PeerSelector Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up everything broken after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Attempt to improve performance of peer task system in pipeline Signed-off-by: Matilda Clerke <[email protected]> * 7311: fix compile check Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken workflow Signed-off-by: Matilda Clerke <[email protected]> * 7311: Reduce logging in JsonRpcExecutor to trace level Signed-off-by: Matilda Clerke <[email protected]> * 7311: More changes in DownloadReceiptsStep Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rework DownloadReceiptsStep Signed-off-by: Matilda Clerke <[email protected]> * 7311: Make changes as discussed in walkthrough meeting Remove DefaultPeerSelector, make EthPeers implement PeerSelector interface, and add PeerTask.getPeerRequirementFilter Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update after merge and make discussed changes from walkthrough discussion Signed-off-by: Matilda Clerke <[email protected]> * 7311: Change to regular HashMap Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove runtime exception again Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rename getPeerTaskBehavior to getPeerTaskRetryBehavior Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rename getPeerTaskBehavior to getPeerTaskRetryBehavior Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rework PeerTaskExecutor retry system to be 0-based Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up compile errors after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken DownloadReceiptsStepTest test Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move GetReceipts to services worker for parallelism Signed-off-by: Matilda Clerke <[email protected]> * 7311: Refactor peer task system usage in DownloadReceiptsStep to better match old system Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove unused async methods in PeerTaskExecutor Signed-off-by: Matilda Clerke <[email protected]> * 7311: Return Optional<EthPeer> in PeerSelector.getPeer and utilise existing peer selection behavior in EthPeers Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Redo getPeer again to include hasAvailableRequestCapacity check Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add protocol spec supplier to GetReceiptsFromPeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rework getPeer again to use LEAST_TO_MOST_BUSY comparator Signed-off-by: Matilda Clerke <[email protected]> * 7311: Import PeerNotConnected class instead of using fully qualified class name Signed-off-by: Matilda Clerke <[email protected]> * 7311: Change to specifying retry counts in PeerTask instead of behavior enums Signed-off-by: Matilda Clerke <[email protected]> * 7311: clean up after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: clean up after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up javadoc Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add additional metrics to PeerTaskExecutor Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add Predicate to PeerTask to check for partial success Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix incorrect name on isPartialSuccessTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement isPartialSuccess and add unit tests Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add partialSuccessCounter and inflightRequestGauge in PeerTaskExecutor Signed-off-by: Matilda Clerke <[email protected]> * 7311: Also filter by whether a peer is fully validated Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove unneeded throws in RunnerTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up inflight requests gauge in PeerTaskExecutor Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update plugin api hash Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update plugin api hash Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add javadoc to LabelledGauge.isLabelsObserved Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update plugin-api hash Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update changelog Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement GetHeadersFromPeerTask and use in DetermineCommonAncestorTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Handle headers with no receipts as a special case in DownloadReceiptsStep Signed-off-by: Matilda Clerke <[email protected]> * 7311: Complete merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Get DetermineCommonAncestorTask working with peer task system Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use taskName instead of className for labelNames Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use snake_case for metric names Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use _total metric name suffix Signed-off-by: Matilda Clerke <[email protected]> * 7311: rework partial success handling Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update GetReceiptsFromPeerTask with partialSuccess changes Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update GetHeadersFromPeerTask with partialSuccess changes Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add default implementation to LabelledGauge.isLabelsObserved Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use Peer task systems GetHeadersFromPeerTask in GetBlockFromPeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken unit test Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove unused constructor from AbstractPeerBlockValidator Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use GetHeadersFromPeerTask in AbstractPeerBlockValidator Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use peer task executor in SyncTargetManager Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix javadoc on BesuControllerBuilder Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove logs used to confirm operation Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement GetHeadersFromPeerTask in FastSyncActions and PivotBlockConfirmer Signed-off-by: Matilda Clerke <[email protected]> * 7311: Rename parseResponse to processResponse Signed-off-by: Matilda Clerke <[email protected]> * 7311: Wrap peer task system usage in ethScheduler call to match other usages Signed-off-by: Matilda Clerke <[email protected]> * 7311: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move check for empty trie hash into GetReceiptsFromPeerTask and update unit test to test for this functionality Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix compile issue after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix compile issue after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove BodyValidator and update code and test to match Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement GetHeadersForPeerTask usage in DownloadHeadersStep Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: remove unneeded logs Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up pre-fill and add test to test failure scenario Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use ProtocolSchedule.anyMatch to find if any ProtocolSpecs are PoS, remove new usages of currentProtocolSpecSupplier Signed-off-by: Matilda Clerke <[email protected]> * 7311: Only attempt to remove headers on successful requests Signed-off-by: Matilda Clerke <[email protected]> * 7311: clean up after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: clean up after merge Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use peer task system in RangeHeadersFetcher Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use peer task system in DownloadHeaderSequenceTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix GetHeadersFromPeerTask mocking in CheckPointSyncChainDownloaderTest Signed-off-by: Matilda Clerke <[email protected]> * 7311: Extract peer task executor answer for getHeaders to separate class for reuse in tests Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement peer task system usage in BackwardSyncStep Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement peer task system usage in ChainHeadTracker Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement peer task system usage in PivotSelectorFromSafeBlock and improve logging Signed-off-by: Matilda Clerke <[email protected]> * 7311: Implement unit test for GetHeadersFromPeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix up merge compile error Signed-off-by: Matilda Clerke <[email protected]> * 7311: Ensure FastSyncActions and PivotSelectorFromSafeBlock retry getting headers for all peers, matching RetryingGetHeaderFromPeerByHashTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: Change PeerTaskExecutorResult.ethPeer to an Optional Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use CancellationException instead of InterruptedException in PivotBlockConfirmer Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use PivotBlockRetriever.MAX_QUERY_RETRIES_PER_PEER to set retries for GetHeadersFromPeerTask Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Add PeerTask.shouldDisconnectPeer and ensure functionality matches old code Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove old info logs Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken test by correctly including peer in PeerTaskExecutorResults in test classes Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix incorrect equality tests Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken test Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move PeerTaskExecutor into EthContext to reduce plumbing changes Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Remove protocol check from GetHeadersFromPeerTask.getPeerRequirementFilter Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken test Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix broken integration test Signed-off-by: Matilda Clerke <[email protected]> * 7311: Refactor peer task validation Signed-off-by: Matilda Clerke <[email protected]> * 7311: Refactor peer task validation Signed-off-by: Matilda Clerke <[email protected]> * 7311: Use peer count for retry count when getting headers in BackwardSyncStep, FastSyncActions, and PivotSelectorFromSafeBlock Signed-off-by: Matilda Clerke <[email protected]> * 7311: spotless Signed-off-by: Matilda Clerke <[email protected]> * 7311: Move chainstate update into GetHeadersFromPeerTask.postProcessResult Signed-off-by: Matilda Clerke <[email protected]> * 7311: Fix compile errors Signed-off-by: Matilda Clerke <[email protected]> * 7311: Update after merge Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* Improve equals performance operation on Address * Use toArrayUnsafe instead of toArray to reduce GC overhead Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* rename file to match convention * allow comments * updated withdrawal request contract address Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* Chore:Removed Deprecated --host-whitelist option * chore: Update everything_config.toml and Updated upcoming Breaking Change in CHANGELOG.md file Signed-off-by: Preeti <[email protected]> --------- Signed-off-by: Preeti <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* Estimate the memory size of EIP-7702 transactions Signed-off-by: Fabio Di Fabio <[email protected]> * Apply suggestions from code review Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* remove evm dep on matter-labs bls12 lib Signed-off-by: garyschulte <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…#8024) * add ignore unknown prop to builder Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Add jfrog check Make homebrew check clearer Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

* Precompute authorities when importing blocks Signed-off-by: Fabio Di Fabio <[email protected]> * Using Supplier to make the authorizer thread safe Signed-off-by: Fabio Di Fabio <[email protected]> * Process code delegation in parallel if there are more that one Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…#8025) * add hotfix to changelog Signed-off-by: Sally MacFarlane <[email protected]> * add 24.12.2 notes Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…ledger#7978) * Add RPC HTTP options to specify custom truststore and it's password * Update error logs to indicate options to use Signed-off-by: Bhanu Pulluri <[email protected]> --------- Signed-off-by: Bhanu Pulluri <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]> Co-authored-by: Bhanu Pulluri <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

…yperledger#8037) * Create a RocksDB opener that display a warning if it takes too much time to open the database * Change the strategy levelCompactionDynamicLevelBytes is set Signed-off-by: Ameziane H. <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>

daniellehrner added the Prague label Dec 7, 2024

daniellehrner commented Dec 7, 2024

View reviewed changes

daniellehrner force-pushed the feat/issue-7994/eip-7623 branch from 5ffe63a to 2fa9022 Compare December 8, 2024 09:27

daniellehrner changed the base branch from main to pectra-devnet-5 December 14, 2024 19:00

daniellehrner marked this pull request as ready for review December 14, 2024 19:02

jflo approved these changes Dec 16, 2024

View reviewed changes

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java Outdated Show resolved Hide resolved

siladu mentioned this pull request Dec 18, 2024

Pectra Devnet 5 Interop Test #8044

Draft

ahamlat and others added 23 commits December 18, 2024 17:59

Fix flaky Clique test waiting for nodes to be fully connected (hyperl…

ad9e24c

…edger#7993) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

remove (empty) versions.gradle (hyperledger#7990)

b9ec6cd

Signed-off-by: Daniel Lehrner <[email protected]>

[CONTRIBUTING] add trivial change clause (hyperledger#7972)

a0c5ff2

Signed-off-by: Daniel Lehrner <[email protected]>

Update CHANGELOG.md for 24.12.0 release (hyperledger#7996)

3dc506a

Update CHANGELOG.md for 24.12.0 release Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Allow frontier simulation when Base Fee is present (hyperledger#7965)

ace78f9

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Support rpc pending block tag when estimating gas (hyperledger#7951)

b35285f

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

first draft for EIP-7623

7fdf028

Signed-off-by: Daniel Lehrner <[email protected]>

adding tests and javadoc comments

f031480

Signed-off-by: Daniel Lehrner <[email protected]>

Update EOFCREATE memory code (hyperledger#7979)

ffad525

* Update EOFCREATE memory code Switch to longs so EOFCREATE can handle gigagas sized transactions. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

account overrides: parse hex string into nonce long (hyperledger#7999)

87631b5

Signed-off-by: Daniel Lehrner <[email protected]>

Small refactoring - Move UnsignedLongParameter to datatypes (hyperled…

45a1cdc

…ger#8001) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Update changelog for 24.12.0-RC2 (hyperledger#8002)

a9160ff

Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Include mention of 24 hours notice for confirmation of outstanding PR…

18c75dc

…s in the release checklist (hyperledger#8004) Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Use unsigned long parameter (hyperledger#8003)

4fc48a5

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Retrieve all transaction receipts for a block in one request (hyperle…

b31edf8

…dger#6646) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Bump besu-native dep to 1.0.0 (hyperledger#8019)

3679726

* remove evm dep on matter-labs bls12 lib Signed-off-by: garyschulte <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Fix BOM pom publication to Artifactory (hyperledger#8021)

a4a3076

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

macfarla and others added 9 commits December 18, 2024 17:59

eth_call state override bugfix - movePrecompileToAddress (hyperledger…

53f74fe

…#8024) * add ignore unknown prop to builder Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Fix simulate pending block timestamp (hyperledger#8027)

303cee6

Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

Update release-checklist.md (hyperledger#8033)

be28482

Add jfrog check Make homebrew check clearer Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

[FLAKE] disable CliqueProposeRpcAcceptanceTests x 2 (hyperledger#8035)

6902ac4

Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>

renamed evmGasUsed to baselineGas

cee6c18

Signed-off-by: Daniel Lehrner <[email protected]>

daniellehrner force-pushed the feat/issue-7994/eip-7623 branch from 24b0efc to cee6c18 Compare December 18, 2024 16:59

daniellehrner merged commit 7a762e9 into hyperledger:pectra-devnet-5 Dec 18, 2024
2 checks passed

siladu mentioned this pull request Jan 10, 2025

EIP-7623 #8093

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-7623 #7997

EIP-7623 #7997

daniellehrner commented Dec 7, 2024

daniellehrner Dec 7, 2024

EIP-7623 #7997

EIP-7623 #7997

Conversation

daniellehrner commented Dec 7, 2024

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

daniellehrner Dec 7, 2024

Choose a reason for hiding this comment