Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve equals performance on Address #8013

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Improve equals performance on Address #8013

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b5d077
Improve equals performance operation on Address
ahamlat Dec 9, 2024
cb768b2
Make equals parameter final
ahamlat Dec 10, 2024
65ad745
Use toArrayUnsafe instead of toArray to reduce GC overhead
ahamlat Dec 10, 2024
1e592ac
Merge branch 'main' into address-equals-perf
ahamlat Dec 10, 2024
53dcba7
Merge branch 'main' into address-equals-perf
macfarla Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions datatypes/src/main/java/org/hyperledger/besu/datatypes/Address.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.hyperledger.besu.ethereum.rlp.RLPException;
import org.hyperledger.besu.ethereum.rlp.RLPInput;

import java.util.Arrays;
import java.util.concurrent.ExecutionException;

import com.fasterxml.jackson.annotation.JsonCreator;
Expand Down Expand Up @@ -291,4 +292,16 @@ public Hash addressHash() {
return Hash.hash(this);
}
}

@Override
public boolean equals(final Object obj) {
if (obj == this) {
return true;
}
if (!(obj instanceof Address)) {
return false;
}
Address other = (Address) obj;
return Arrays.equals(this.toArray(), other.toArray());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using toArrayUnsafe, which will use local copies of the bytes if they exist, and will have less GC churn. (if a local copy does not exist it will go back to toArray)

As long as we never manipulate the bytes that are returned it will be safe. The Unsafe part only denotes we are exposing an internal array.

}
}
Loading