-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-plugin-ledger-connector-ethereum): support London fork gas prices #2630
Conversation
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Outdated
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Outdated
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Outdated
Show resolved
Hide resolved
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Please resolve the merge conflicts, rebase, squash as needed, etc and then pass it back for review!
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]>
This PR/issue depends on:
|
9a7dc2c
to
b78f835
Compare
b78f835
to
bce2858
Compare
…s prices - Add legacy and EIP1559 gas configuration options to transaction requests. - Legacy gas configuration is updated to EIP1559 using the same logic as web3 libraries. - Update the tests to work with new API. - Added test suite to test new features - `geth-transact-and-gas-fees.test.ts` Depends on: hyperledger-cacti#2581 Signed-off-by: Michal Bajer <[email protected]>
bce2858
to
80a89dd
Compare
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]>
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]>
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Co-authored-by: Peter Somogyvari <[email protected]> 1. Updated the yarn.lock file to reflect the changes in the package.json Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
- Refactor to single `invokeContract` endpoint that can accept multiple methods of supplying contract definition (directly, from keychain, etc..). - Same for `deployContract` method. - Update cactus-common `safeStringifyException` function to better handle axios errors (and other custom exceptions that support `toJSON()` method.). - Use common error handling in all connector endpoints (except prometheus). - Fix the tests. - Switch to `Cacti` work in entire connector (except for package name) Co-authored-by: Peter Somogyvari <[email protected]> 1. Updated the yarn.lock file to reflect the changes in the package.json Depends on: hyperledger-cacti#2630 Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
geth-transact-and-gas-fees.test.ts
Depends on #2581
Signed-off-by: Michal Bajer [email protected]