-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(connector-iroha): fix and unskip run-transaction-endpoint-v1.test #1957
Comments
Hey @petermetz, just wanted to let you know that I've ran the test case at least 20 times (without any changes except not skipping the test cases anymore) and it has passed every single one of them. I've put up an issue mentioning this "fix" where I got rid of the |
@Leeyoungone Nice, let's see how it goes. I don't remember for sure if we skipped it because it wasn't working at all or if it was flaky. We can start not skipping it and monitor the CI runs on unrelated PRs for failures due to this test case (if it starts being flaky we'll have to reverse your change and reopen this issue until we figure out the reason for the flaky execution of the test case) |
@petermetz sounds good! thanks for your thoughts :)) |
removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Currently this test case is being skipped due to issues with the Iroha AIO image: packages/cactus-plugin-ledger-connector-iroha/src/ test/typescript/integration/ run-transaction-endpoint-v1.test.ts removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Currently this test case is being skipped due to issues with the Iroha AIO image: packages/cactus-plugin-ledger-connector-iroha/src/ test/typescript/integration/ run-transaction-endpoint-v1.test.ts removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Currently this test case is being skipped due to issues with the Iroha AIO image: packages/cactus-plugin-ledger-connector-iroha/src/ test/typescript/integration/ run-transaction-endpoint-v1.test.ts removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Currently this test case is being skipped due to issues with the Iroha AIO image: packages/cactus-plugin-ledger-connector-iroha/src/ test/typescript/integration/ run-transaction-endpoint-v1.test.ts removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Currently this test case is being skipped due to issues with the Iroha AIO image: packages/cactus-plugin-ledger-connector-iroha/src/ test/typescript/integration/ run-transaction-endpoint-v1.test.ts removal of skip resulted in the test case passing over 20 times, might still be flaky. Fixes hyperledger-cacti#1957 Signed-off-by: Youngone Lee <[email protected]>
Description
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Acceptance criteria
The text was updated successfully, but these errors were encountered: