Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): supply chain example container image exact versions #751

Closed
petermetz opened this issue Mar 30, 2021 · 0 comments · Fixed by #752
Closed

fix(docs): supply chain example container image exact versions #751

petermetz opened this issue Mar 30, 2021 · 0 comments · Fixed by #752
Assignees
@petermetz
Labels
bug Something isn't working

Comments

@petermetz
Copy link
Contributor

Describe the bug

Right now the dockerfile of the supply chain app example specifies exact versions to apk when installing dependencies and over time this has broken the build.

To Reproduce

Try to build the image. See that it fails.

Expected behavior

Image build succeeds.

Logs/Stack traces

N/A

Screenshots

N/A

Operating system name, version, build:

N/A/

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

N/A

Hyperledger Cactus Plugins/Connectors Used

Fabric, Besu, Quorum

Additional context

The docker hub automated builds are also failing due to the same bug.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
@petermetz petermetz added the bug Something isn't working label Mar 30, 2021
@petermetz petermetz self-assigned this Mar 30, 2021
@petermetz petermetz changed the title fix(examples): supply chain app container image apk versions fix(docs): supply chain example container image exact versions Mar 30, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 30, 2021
@petermetz
fix(docs): supply chain example container image exact versions hyperl…
6cccd9d 
…edger-cacti#751

Remove the specific versions from the Dockerfile so that instead what
gets installed is "whatever's latest that day". This is not preferred, but
since Alpine Package Manager disappears versions of packages after
the fact, we do not have a choice but to abandon our quest for
reproducible builds in this particular instance.

Fixes hyperledger-cacti#751

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 30, 2021
@petermetz
fix(docs): supply chain example container image exact versions hyperl…
3dc564b 
…edger-cacti#751

Remove the specific versions from the Dockerfile so that instead what
gets installed is "whatever's latest that day". This is not preferred, but
since Alpine Package Manager disappears versions of packages after
the fact, we do not have a choice but to abandon our quest for
reproducible builds in this particular instance.

Fixes hyperledger-cacti#751

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Mar 30, 2021
Merged
petermetz added a commit that referenced this issue Apr 2, 2021
@petermetz
fix(docs): supply chain example container image exact versions #751
bfc9c19 
Remove the specific versions from the Dockerfile so that instead what
gets installed is "whatever's latest that day". This is not preferred, but
since Alpine Package Manager disappears versions of packages after
the fact, we do not have a choice but to abandon our quest for
reproducible builds in this particular instance.

Fixes #751

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): supply chain example container image exact versions #751 petermetz/cacti
1 participant
@petermetz