Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github pages documentation #80

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

jt-nti
Copy link
Member

@jt-nti jt-nti commented Apr 6, 2022

Publish generated API documentation for the .proto files

Signed-off-by: James Taylor [email protected]

@bestbeforetoday
Copy link
Member

Looks like good progress to me. I wonder if we should also generate and publish API documentation (tsdoc, javadoc) from the compiled bindings, unless that's already happening somewhere I missed and is what the protos.md link points to?

@jt-nti
Copy link
Member Author

jt-nti commented Apr 7, 2022

@bestbeforetoday good point, I've opened issue #82 to cover both (the generated protos.md is a language agnostic API doc for the protos)

@jt-nti jt-nti force-pushed the proto-docs branch 9 times, most recently from 435f080 to 01ce287 Compare May 13, 2022 14:52
Publish generated API documentation for the .proto files

Signed-off-by: James Taylor <[email protected]>

# Conflicts:
#	Makefile
#	buf.gen.yaml
@jt-nti jt-nti changed the title [WIP] Add github pages documentation Add github pages documentation May 13, 2022
@jt-nti jt-nti marked this pull request as ready for review May 13, 2022 15:03
@jt-nti jt-nti requested a review from a team as a code owner May 13, 2022 15:03
@andrew-coleman andrew-coleman merged commit 2929949 into hyperledger:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants