Upgrade Jinja2 to v3.1.3 #4613
Merged
Upgrade Jinja2 to v3.1.3 #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of Sphinx we were using is simply not compatible with Jinja2 > v3.0.3, so given that we had to upset the delicate balance of requirements anyway, the goal of this PR is now to bring all docs infrastructure for CI/CD as well as dependencies and indeed the docs themselves to the latest version. Signed-off-by: Ben Smith <[email protected]>
denyeart
approved these changes
Jan 17, 2024
|
Detailed review complete! |
|
@Mergifyio backport release-2.5 |
✅ Backports have been created
|
|
@benjsmi The automated backport to release-2.5 failed due to merge conflicts. Do you want to create a release-2.5 PR manually? |
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the main branch.
The version of Sphinx we were using is simply not compatible with Jinja2 > v3.0.3, so given that we had to upset the delicate balance of requirements anyway, the goal of this PR is now to bring all docs infrastructure for CI/CD as well as dependencies and indeed the docs themselves to the latest version.
Type of change
Description
Motivation is https://nvd.nist.gov/vuln/detail/CVE-2024-22195, quite simply. But the version of Sphinx that we were using was many years old and does not support a version of Jinja higher than v3.0.3. So we need to update the entire set of dependencies for the documentation.
Additional details
I will make whatever changes are needed to the docs and/or to the CI/CD pipeline to make this compatible with Sphinx v7.2.6, which is the latest. Please let me know if something isn't right or needs fixing, because this is the time to do it.
Related issues
Release Note
This change does NOT impact users of Fabric, nor shall it impact the functionality of any release, past, future, present. We are also unlikely to merge it until the docs look correct on RTD. But be advised that they may indeed change.