Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(castor) Add did verification capabilities #20

Merged
merged 6 commits into from
Feb 2, 2023
Merged

feat(castor) Add did verification capabilities #20

merged 6 commits into from
Feb 2, 2023

Conversation

elribonazo
Copy link
Contributor

Overview

Integrates the verification capabilities in Castor, this method is expecting to receive a DID, challenge and signature and the method resolves a did and using apollo verifies public signatures.

Added very minimal test coverage here.

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

@hamada147
Copy link
Contributor

hamada147 commented Feb 1, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ KOTLIN ktlint 8 6 0 32.48s
✅ REPOSITORY checkov yes no 17.22s
✅ REPOSITORY devskim yes no 0.76s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 2.08s
✅ REPOSITORY syft yes no 1.01s
✅ REPOSITORY trivy yes no 4.52s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@elribonazo elribonazo marked this pull request as ready for review February 2, 2023 09:38
@elribonazo elribonazo requested a review from hamada147 February 2, 2023 09:38
cristianIOHK
cristianIOHK approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elribonazo elribonazo merged commit 96c3105 into main Feb 2, 2023
elribonazo added a commit that referenced this pull request Feb 2, 2023
@elribonazo
Merge branch 'main' into feature/ATL-2475
e6abde8 
* main:
  feat(castor) Add did verification capabilities (#20)

# Conflicts:
#	castor/build.gradle.kts
#	castor/src/commonMain/kotlin/CastorImpl.kt
#	castor/src/commonMain/kotlin/io/iohk/atala/prism/castor/resolvers/PeerDIDResolver.kt
@amagyar-iohk amagyar-iohk deleted the feature/ATL-2432 branch September 20, 2023 11:14
hamada147 pushed a commit that referenced this pull request May 15, 2024
@elribonazo @hamada147
feat(castor) Add did verification capabilities (#20)
0fed9ef 
* Adding Castor Verify signature method
* add verifySignatureJS for Javascript (browser, nodejs) with promise.
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Javi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

@hamada147 hamada147 Awaiting requested review from hamada147

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elribonazo @hamada147 @cristianIOHK