Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pluto) Database initialisation and connection state checking #30

Merged
merged 12 commits into from
Feb 13, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Feb 12, 2023

Overview

This fixed Pluto from not being capable of detecting if the database connection already exists or not. If we left it like this we could not prevent the user from running a query on a non established connection.

First, have improved the DBConnection expects and implemented each variation that we required.
Integrated all the required files for Javascript (browser,nodejs) support with sqljs wasm.
Integrated minimal test coverage running an all platforms.
Added Database start and stop commands to establish or close a connection.
Improved error handling a lot, on Android when application context is not send, and in the rest of pluto when something is queries without an active connection.
Also added an extension for the SQLDriver in order to be capable of telling if the connection is active or closed.

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

@hamada147
Copy link
Contributor

hamada147 commented Feb 12, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JAVASCRIPT standard 4 4 0 2.72s
✅ KOTLIN ktlint 24 2 0 49.76s
✅ REPOSITORY checkov yes no 11.7s
✅ REPOSITORY devskim yes no 0.73s
✅ REPOSITORY dustilock yes no 0.02s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY syft yes no 0.88s
✅ REPOSITORY trivy yes no 2.98s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@elribonazo elribonazo merged commit 93884d5 into main Feb 13, 2023
@elribonazo elribonazo deleted the feature/ATL-3497 branch February 13, 2023 11:25
hamada147 pushed a commit that referenced this pull request May 15, 2024
* Fix issues with Javascript integration, use Library and not executable.
* Integrate platform to better check if platform is of one type or another.
* Integrate Pluto Database connection with native support + unit testing.
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Javi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants