-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pluto) Database initialisation and connection state checking #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
goncalo-frade-iohk
approved these changes
Feb 13, 2023
hamada147
pushed a commit
that referenced
this pull request
May 15, 2024
* Fix issues with Javascript integration, use Library and not executable. * Integrate platform to better check if platform is of one type or another. * Integrate Pluto Database connection with native support + unit testing. Co-authored-by: Ahmed Moussa <[email protected]> Signed-off-by: Javi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixed Pluto from not being capable of detecting if the database connection already exists or not. If we left it like this we could not prevent the user from running a query on a non established connection.
First, have improved the DBConnection expects and implemented each variation that we required.
Integrated all the required files for Javascript (browser,nodejs) support with sqljs wasm.
Integrated minimal test coverage running an all platforms.
Added Database start and stop commands to establish or close a connection.
Improved error handling a lot, on Android when application context is not send, and in the rest of pluto when something is queries without an active connection.
Also added an extension for the SQLDriver in order to be capable of telling if the connection is active or closed.
My PR contains...