fix(rn): do not try to deserialize again if it is a stream (#234)

hyperledger · Nov 1, 2023 · c1678df · c1678df
1 parent aa7645b
commit c1678df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/wrappers/javascript/indy-vdr-react-native/src/NativeBindings.ts b/wrappers/javascript/indy-vdr-react-native/src/NativeBindings.ts
@@ -1,4 +1,5 @@
 import type { Callback, CallbackWithResponse, ReturnObject } from './serialize'
+import type { Transactions } from '@hyperledger/indy-vdr-shared'
 
 export type PoolHandle = number
 export type RequestHandle = number
@@ -127,7 +128,7 @@ export interface NativeBindings {
 
   poolGetStatus(options: { poolHandle: PoolHandle; cb: CallbackWithResponse<string> }): ReturnObject<never>
 
-  poolGetTransactions(options: { poolHandle: PoolHandle; cb: CallbackWithResponse<string> }): ReturnObject<never>
+  poolGetTransactions(options: { poolHandle: PoolHandle; cb: CallbackWithResponse<Transactions> }): ReturnObject<never>
 
   poolGetVerifiers(options: { poolHandle: PoolHandle; cb: CallbackWithResponse<string> }): ReturnObject<never>
 

diff --git a/wrappers/javascript/indy-vdr-react-native/src/ReactNativeIndyVdr.ts b/wrappers/javascript/indy-vdr-react-native/src/ReactNativeIndyVdr.ts
@@ -74,7 +74,7 @@ export class ReactNativeIndyVdr implements IndyVdr {
     isStream = false
   ): Promise<Return | null> => {
     return new Promise((resolve, reject) => {
-      const _cb: CallbackWithResponse = ({ value, errorCode }) => {
+      const cb: CallbackWithResponse = ({ value, errorCode }) => {
         if (errorCode !== 0) reject(new IndyVdrError(JSON.parse(this.getCurrentError()) as IndyVdrErrorObject))
 
         // this is required to add array brackets, and commas, to an invalid json object that
@@ -89,7 +89,7 @@ export class ReactNativeIndyVdr implements IndyVdr {
         }
       }
 
-      method(_cb)
+      method(cb)
     })
   }
 
@@ -255,10 +255,10 @@ export class ReactNativeIndyVdr implements IndyVdr {
   public async poolGetTransactions(options: { poolHandle: PoolHandle }): Promise<Transactions> {
     const { poolHandle } = serializeArguments(options)
     const result = handleInvalidNullResponse(
-      await this.promisifyWithResponse<string>((cb) => this.indyVdr.poolGetTransactions({ cb, poolHandle }), true)
+      await this.promisifyWithResponse<Transactions>((cb) => this.indyVdr.poolGetTransactions({ cb, poolHandle }), true)
     )
 
-    return JSON.parse(result) as Transactions
+    return result
   }
 
   public async poolGetVerifiers(options: { poolHandle: PoolHandle }): Promise<Verifiers> {