Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .net wrapper #100

Closed
wants to merge 2 commits into from
Closed

Added .net wrapper #100

wants to merge 2 commits into from

Conversation

CHempel-esatus
Copy link

Signed-off-by: Christopher Hempel [email protected]

@swcurran
Copy link
Member

@CHempel-esatus — thanks for this. The DCO is failing — can you fix that? DCO - Developer Certificate of Origin - https://github.com/apps/dco. We have to have that fixed before we can merge this. Let us know if you need help with that.

@CHempel-esatus
Copy link
Author

@swcurran I will fix it.

Signed-off-by: CHempel <[email protected]>
@CHempel-esatus
Copy link
Author

@swcurran DCO is fixed.

Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have too much experience with wrappers in .NET, but it seems there's test so I'm approving this PR 👍

Did you update the PR with all the changes related to did:indy that have been applied?

Would be good to also set up some CI so it becomes just as easy to deploy the .NET wrapper as it is for the JS/Python wrappers

@swcurran
Copy link
Member

swcurran commented Dec 4, 2023

@CHempel-esatus -- do you plan to move this forward? Unfortunately, I can't update the PR to merge in the latest main branch updates, so can't move this forward.

I'll close the PR with this note, but would be fine if you want to reopen it and move it forward.

@swcurran swcurran closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants