fix(js): defer library loading for nodejs #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
berendsliedrecht
requested changes
Mar 14, 2023
Comment on lines
73
to
74
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
Both of these can be removed now.
| @@ -3,13 +3,13 @@ import type { IndyVdrErrorObject } from '@hyperledger/indy-vdr-shared' | |||
| import { IndyVdrError } from '@hyperledger/indy-vdr-shared' | |||
|
|
|||
| import { allocateString } from './ffi' | |||
| import { nativeIndyVdr } from './library' | |||
| import { getNativeIndyVdr } from './library' | |||
|
|
|||
| export const handleError = (code: number) => { | |||
There was a problem hiding this comment.
Seeing this now, I would say it makes more sense to have handleError as a private method on the NodeJSIndyVdr class. Could you include that in the PR?
Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent native library from being loaded right when
@hyperledger/indy-vdr-nodejsis imported by deferring its loading to when it's actually used.This is a problem we found during AFJ test suites, which import the library in general purpose test helpers and make the native library to be loaded more times than needed, allocating more memory and making the suite to crash.