fix(compaction): Don't use cache for table compaction #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: db.go levels.go options.go table/builder.go table/builder_test.go table/table.go value.go
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
manishrjain
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Reviewed 1 of 9 files at r3, 5 of 12 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR adds support for disabling cache while doing compactions. Compactions read the entire table and pushing all data through the cache would unnecessarily evict everything from the cache. Table Iterator options are represented as integers ``` REVERSE = 2 NOCACHE = 4 ``` The `table.Block(...)` call with not push the block in cache if `NOCACHE` is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for disabling cache while doing compactions.
Compactions read the entire table and pushing all data through the cache
would unnecessarily evict everything from the cache.
Table Iterator options are represented as integers
The
table.Block(...)call with not push the block in cache ifNOCACHEis set.This change is