fix(writeBatch): Avoid deadlock in commit callback #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wb.Flush() would call wb.commit() while holding lock which would call wb.callback in case of an error while committing. wb.callback would try to acquire the lock wb.Flush is holding and this would lead to a deadlock. This PR fixes it.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
wb.Flush() would call wb.commit() while holding lock which would call wb.callback in case of an error while committing. wb.callback would try to acquire the lock wb.Flush is holding and this would lead to a deadlock. This PR fixes it.
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 17, 2023
Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
Signed-off-by: thomassong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wb.Flush()would callwb.commit()while holding lock which would callwb.callbackin case of an error while committing.wb.callbackwould try to acquire the lockwb.Flushis holding and thiswould lead to a deadlock. This PR fixes it.
The test in this PR fails on master.
This change is