Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow error when building for 386 #1541

Merged
merged 6 commits into from
Oct 2, 2020
Merged

Fix integer overflow error when building for 386 #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc3c766
Fix integer overflow error when building for 386
gammazero Sep 24, 2020
00dbef1
uint32 instead of int64
gammazero Sep 24, 2020
0271bf6
additional 32bit fixes
gammazero Sep 24, 2020
8afebcb
Use math.MaxInt32 as max int value
gammazero Sep 24, 2020
5077e99
remove unneeded cast
gammazero Sep 26, 2020
8163afd
Update value.go
gammazero Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion badger/cmd/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func doBackup(cmd *cobra.Command, args []string) error {
opt := badger.DefaultOptions(sstDir).
WithValueDir(vlogDir).
WithTruncate(truncate).
WithNumVersionsToKeep(math.MaxUint32)
WithNumVersionsToKeep(math.MaxInt32)

if numVersions > 0 {
opt.NumVersionsToKeep = numVersions
Expand Down
2 changes: 1 addition & 1 deletion badger/cmd/restore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func doRestore(cmd *cobra.Command, args []string) error {
// Open DB
db, err := badger.Open(badger.DefaultOptions(sstDir).
WithValueDir(vlogDir).
WithNumVersionsToKeep(math.MaxUint32))
WithNumVersionsToKeep(math.MaxInt32))
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import (

// maxVlogFileSize is the maximum size of the vlog file which can be created. Vlog Offset is of
// uint32, so limiting at max uint32.
var maxVlogFileSize = math.MaxUint32
var maxVlogFileSize uint32 = math.MaxUint32

// Values have their first byte being byteData or byteDelete. This helps us distinguish between
// a key that has never been seen and a key that has been explicitly deleted.
Expand Down