KeySplits checks tables and memtables when number of splits is small. #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmr
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
- fix prefix logic. - iterate in reverse order. - use modulo to get at least one split per table.
Also added more logging.
martinmr
changed the title
manishrjain
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Reviewed 4 of 5 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @martinmr)
db.go, line 1484 at r3 (raw file):
// If the number of splits is still < 32, then look at the memtables. if len(splits) < 32 { maxPerSplit := 10000
keysPerSplit
manishrjain
reviewed
Oct 1, 2020
There was a problem hiding this comment.
Also change batchSize in stream to 16MB.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @martinmr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2509
This change is