fix(subcompaction): Close builder before throttle.Done #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition in the subcompaction code which was caused because we were doing builder.Close after doing throttle.Done in subcomapction. This PR fixes that race condition by calling builder.Done before calling throttle.Done .
NamanJain8
approved these changes
Nov 5, 2020
ahsanbarkati
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in the subcompaction code which was caused
because we were doing builder.Close after doing throttle.Done in
subcomapction. This PR fixes that race condition by calling builder.Done
before calling throttle.Done .
This change is