Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add missing unlock in TestPersistLFDiscardStats #1924

Merged
merged 3 commits into from
May 4, 2023
Merged

fix(test): add missing unlock in TestPersistLFDiscardStats #1924

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867baf6
increase wait for compaction to finish and add explicit unlock
Apr 12, 2023
33e98da
increase sleep
Apr 12, 2023
8e8b25f
Remove extra sleeps
joshua-goldstein May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions value_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,7 @@ func TestPersistLFDiscardStats(t *testing.T) {
persistedMap[fid] = val
})

db.vlog.discardStats.Unlock()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it odd that we were acquiring the lock before and not calling unlock. Could you elaborate more on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found that very odd. I have no insight into why it was like this. Probably an oversight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like db variable is re-assigned and hence calling Lock again without Unlock is not a problem. But this is better.

require.NoError(t, db.Close())

// Avoid running compactors on reopening badger.
Expand Down